Adservio Code Review Analysis
A read-only analysis of recent merge request review behavior in GitLab, focused on visible review discussion, reviewer distribution, queue health, MR size, and traceability gaps.
Executive Summary
Bottom line: review throughput is not the main risk here; traceability and queue hygiene are. The team is still merging code, but most merges leave no durable visible review trail and the open queue is overwhelmingly stale.
What Matters
- Traceability is the clearest control gap: 34 of 39 merged MRs (87.2%) showed no visible non-author review comment in GitLab.
- `CR - Approved` is currently too weak as evidence on its own: 46.2% of merged MRs carried that label without any visible review discussion.
- Queue health is poor: 80.4% of active open MRs are already older than 48 working hours. The oldest example is adservio/web!2091 at 261.5d open.
- Visible review capacity is thin and concentrated: only 6 visible review touches were detected in the whole window, and the top 3 reviewers handled 66.7% of them.
- adservio/frontend is the highest-volume review surface with 15 merged MRs and only 20.0% visible review coverage. adservio/helm2 is the next meaningful flow at 7 merges and 0.0% visible review coverage.
- MR size is not the main story: median changed files were 4, and only 17.9% of merged MRs were above 20 files. Even the slowest merged example, adservio/frontend!1633, took 92.8d with 69 changed files, so the dominant problem still looks like review discipline and queue ownership rather than consistently oversized MRs.
Leadership Analysis
- The operating rhythm is serviceable at the median (42.4h created-to-merged), which means the biggest leverage is improving process fidelity rather than pushing for even more raw throughput.
- With 80.4% of active MRs already stale, the open list is functioning more like inventory than prioritization support. adservio/web!2091 being open for 261.5d is a strong sign that ownership and review handoffs are not being actively reset.
- Reviewer concentration is now a resilience issue, not just a fairness issue. When the top 3 reviewers carry 66.7% of visible touches, review quality, continuity, and queue health all become sensitive to a very small set of people.
- The spread between a 4-file median MR and a 92.8d longest merged cycle (adservio/frontend!1633, 69 changed files) suggests a few ownership-heavy exceptions are dragging on outside normal flow. Those should be managed as explicit escalations, not left to age inside the common queue.
Recommended Actions
- Make one durable review artifact mandatory before merge: a substantive non-author GitLab review comment, a recorded approval, or both. A label alone should no longer count as sufficient evidence. The approval API coverage is also low, so the fix should include tooling or policy that leaves an auditable trace by default.
- Run a stale-MR reset on anything older than 48 working hours: close abandoned work, re-confirm owner and reviewer on the rest, and turn the open list back into a real queue instead of a parking lot. Start with adservio/web!2091 and the rest of the oldest backlog because their age now obscures whether they are still real priorities.
- Put adservio/helm2 under explicit review guardrails for the next cycle. It combines enough volume with weak visible review coverage, which makes it the best place to tighten the process and see impact quickly.
- Broaden the reviewer bench beyond Achim Stefan and the current small reviewer set. The present concentration is a continuity risk and will keep queue health fragile when one person is away.
Improvement Ideas
- Set explicit operating standards for the next quarter: require one auditable peer-review artifact before merge, target first review inside one working day for active MRs, and keep the stale active backlog below 15%. What gets measured this clearly is far more likely to improve.
- Run a four-week process experiment on adservio/helm2: dedicated reviewer-of-the-week coverage, explicit reviewer assignment at MR creation, and a lightweight weekly audit of silent merges. It is the highest-yield place to test whether better ownership changes the data.
- Create a reviewer rotation with named backup coverage for the busiest repos. Good review systems depend on redundancy, not heroics, and rotation is the fastest way to lower reviewer bus factor without slowing delivery.
Supporting Evidence
- 34 of 39 merged MRs (87.2%) had no visible non-author review comment in GitLab.
- 23 of 39 merged MRs (59.0%) carried the `CR - Approved` label.
- 18 merged MRs (46.2%) were labeled `CR - Approved` without any visible non-author review comment.
- 17.9% of merged MRs changed more than 20 files, while 7.7% changed more than 50 files.
- Among MRs with visible review discussion, the median last-author-commit to first-review time was 16.1h.
- The median last-author-commit to `CR - Approved` time was 15.7h.
- The top 3 reviewers accounted for 66.7% of visible review touches.
- 41 of 51 active open MRs (80.4%) were older than 48 working hours.
Merged MRs Merged MRs inside the analysis window. | 39 |
Open MRs All currently open group MRs. | 61 |
Active open MRs Open MRs excluding drafts. | 51 |
Draft open MRs Open MRs marked draft/WIP. | 10 |
Visible review rate Merged MRs with at least one visible non-author GitLab comment. | 12.8% |
Merged without visible review comment Merged MRs with zero visible non-author comments. | 87.2% |
CR - Approved label coverage Merged MRs carrying the CR-approved label. | 59.0% |
Approval API coverage Merged MRs with at least one approver in the GitLab approvals API. | 28.2% |
CR - Approved without visible review comment CR-approved MRs with no visible non-author comment. | 46.2% |
Median MR created -> first review Working time from MR creation to first visible non-author comment. | 46.1h |
Median last author commit -> first review Working time from last author commit before review to first visible non-author comment. | 16.1h |
Median first review -> CR - Approved Working time from first visible comment to CR-approved label after review start, else merge. | 1.3h |
Median MR created -> CR - Approved Working time from MR creation to CR-approved label after review start, else merge. | 45.6h |
Median last author commit -> CR - Approved Working time from last author commit before review to CR-approved label after review start, else merge. | 15.7h |
Median MR created -> merged Working time from MR creation to merge. | 42.4h |
Median changed files Median GitLab `changes_count` value. | 4 |
MRs > 5 files Merged MRs where `changes_count` is above 5. | 43.6% |
MRs > 10 files Merged MRs where `changes_count` is above 10. | 25.6% |
MRs > 20 files Merged MRs where `changes_count` is above 20. | 17.9% |
MRs > 50 files Merged MRs where `changes_count` is above 50. | 7.7% |
Top 3 reviewer touch share Share of visible review touches handled by the top 3 reviewers. | 66.7% |
Active open backlog rate Non-draft open MRs older than 48 working hours. | 80.4% |
Timing Breakdown
These headline timing medians bring back the anchor-to-anchor numbers directly, using working time with weekends excluded.
| Median MR created -> first review | 46.1h |
| Median last author commit -> first review | 16.1h |
| Median MR created -> CR - Approved | 45.6h |
| Median first review -> CR - Approved | 1.3h |
| Median last author commit -> CR - Approved | 15.7h |
| Median MR created -> merged | 42.4h |
Reviewer Distribution
| Achim Stefan | 2 | 7 | 33.3% |
| Daniel Onisoru | 1 | 1 | 16.7% |
| Dragoș Ivan | 1 | 8 | 16.7% |
| Andrei Dragan | 1 | 8 | 16.7% |
| Ioana Ivan | 1 | 2 | 16.7% |
Repo Breakdown
| adservio/frontend | 15 | 20.0% | 93.3% | 6 |
| adservio/helm2 | 7 | 0.0% | 0.0% | 1 |
| adservio/uni/backend | 5 | 20.0% | 40.0% | 22 |
| adservio/devops/iac | 4 | 0.0% | 0.0% | 3.0 |
| adservio/web | 3 | 33.3% | 100.0% | 1 |
| adservio/docgen2/backend | 2 | 0.0% | 100.0% | 5.0 |
| adservio/accommodations/backend | 1 | 0.0% | 0.0% | 12 |
| adservio/admission/backend | 1 | 0.0% | 100.0% | 5 |
| adservio/billing/backend | 1 | 0.0% | 100.0% | 3 |
Visible Review Discussion MRs
Compact by default: key CR metrics stay visible, and each row expands inline for the full audit trail. The table starts sorted by Last Commit -> First Review.
| Details | ||||||
|---|---|---|---|---|---|---|
| adservio/frontend!2006 | [ADS-7952]: Implementare Atribute | 4/5 Strong | 19.8h | 0.7h | 20.9h | |
Repo adservio/frontend Author Dana Mihaela Maritca Reviewers Achim Stefan Review Comments 6 Quality Notes 6 visible comments; 6 substantive comments; single reviewer; 4 post-review pushes; multi-point discussion Substantive Comments 6 Reviewer Count 1 Post-Review Pushes 4 MR Created 2026-07-10 16:11 Last Author Commit 2026-07-13 11:20 First Review 2026-07-13 12:01 CR Approved 2026-07-13 13:03 Merged 2026-07-16 16:29 First Review -> CR Approved 1.0h Last Commit -> CR Approved 1.7h Created -> Merged 4.0d | ||||||
| adservio/frontend!2027 | [ADS-8257] Eroare 400 la debifare afisare in catalog a unui transfer intre clase | 3/5 Solid | 2.5h | 2.6h | 3.9h | |
Repo adservio/frontend Author Petronel Pavel Reviewers Ioana Ivan Review Comments 2 Quality Notes 2 visible comments; 1 substantive comment; single reviewer; 1 post-review push Substantive Comments 1 Reviewer Count 1 Post-Review Pushes 1 MR Created 2026-07-17 11:03 Last Author Commit 2026-07-17 11:02 First Review 2026-07-17 13:36 CR Approved 2026-07-17 14:55 Merged 2026-07-17 22:14 First Review -> CR Approved 1.3h Last Commit -> CR Approved 3.9h Created -> Merged 11.2h | ||||||
| adservio/frontend!2003 | [ADS-8205]: Add route for teacher details modal for Calendar. | 2/5 Light | 46.1h | 16.1h | 45.6h | |
Repo adservio/frontend Author Ioana Ivan Reviewers Achim Stefan Review Comments 1 Quality Notes 1 visible comment; 1 substantive comment; single reviewer Substantive Comments 1 Reviewer Count 1 Post-Review Pushes 0 MR Created 2026-07-09 12:07 Last Author Commit 2026-07-10 18:06 First Review 2026-07-13 10:11 CR Approved 2026-07-13 09:45 Merged 2026-07-13 09:45 First Review -> CR Approved 0.0h Last Commit -> CR Approved 15.7h Created -> Merged 45.6h | ||||||
| adservio/web!2640 | [ADS-7849][ADS-8202] Stergere date S3 - Logheaza incercarile de autentificare pentru fluxurile de login | 1/5 Very light | 2.3d | 2.3d | 3.0d | |
Repo adservio/web Author Catalin Cojan Reviewers Daniel Onisoru Review Comments 1 Quality Notes 1 visible comment; comments look lightweight; single reviewer Substantive Comments 0 Reviewer Count 1 Post-Review Pushes 0 MR Created 2026-07-10 10:09 Last Author Commit 2026-07-10 10:08 First Review 2026-07-14 16:51 CR Approved 2026-07-15 10:29 Merged 2026-07-15 10:29 First Review -> CR Approved 17.6h Last Commit -> CR Approved 3.0d Created -> Merged 3.0d | ||||||
| adservio/uni/backend!219 | [ADS-7497] Graduation module | 4/5 Strong | 6.0d | 2.8d | 17.2d | |
Repo adservio/uni/backend Author Ionut Ciolan Reviewers Dragoș Ivan, Andrei Dragan Review Comments 16 Quality Notes 16 visible comments; 15 substantive comments; 2 reviewers; multi-point discussion Substantive Comments 15 Reviewer Count 2 Post-Review Pushes 0 MR Created 2026-06-23 11:03 Last Author Commit 2026-06-26 15:07 First Review 2026-07-01 10:53 CR Approved 2026-07-16 16:52 Merged 2026-07-16 17:12 First Review -> CR Approved 11.2d Last Commit -> CR Approved 14.1d Created -> Merged 17.3d | ||||||
No Visible Review Comment Audit
These merged MRs had no visible non-author GitLab comment under the current heuristic. Use this section to audit whether the gap is a real review-process issue or a GitLab traceability issue.
Total MRs34
With CR Label18
With Approval API9
- Open the MR link and check the Overview tab for
CR - Approvedand any approval widget signal. - Check Activity / Discussions for real human reviewer comments.
- If you only see system notes, merge notes, mentions, or bot activity, it stays in this audit set.
- If you find a genuine reviewer comment from someone other than the author, treat that MR as a false positive of this heuristic.
full audit table (34 MRs). Click again to collapse.
| adservio/accommodations/backend!73 | adservio/accommodations/backend | [ADS-8104] Summer contract 2026 + seeder | Ionut Ciolan | 2026-07-12 | ||
| adservio/admission/backend!182 | adservio/admission/backend | Revert "logs for personal info" | George Murgoci | 2026-07-13 | Yes | |
| adservio/frontend!2010 | adservio/frontend | [ADS-6638] Refactor pagina de gestionare notificări | Petronel Pavel | 2026-07-13 | Yes | |
| adservio/frontend!1633 | adservio/frontend | [ADS-6545]: WebBridge SDK | Dragoș Ivan | 2026-07-13 | Yes | |
| adservio/frontend!2011 | adservio/frontend | [ADS-6545] [DO NOT MERGE]: WebBridge SDK Exemple | Ioana Ivan | 2026-07-13 | ||
| adservio/helm2!310 | adservio/helm2 | prod tempo: raise OTLP receiver gRPC max_recv_msg_size to 32MiB (ADS-7961 regression) | Rojan Shrestha | 2026-07-13 | ||
| adservio/helm2!311 | adservio/helm2 | ads-8043 lower web cron peak from 24 to 12 replicas for summer traffic | Rojan Shrestha | 2026-07-13 | ||
| adservio/web!2643 | adservio/web | [ADS-8224] La editarea elevului, campul "rol" nu afiseaza optiuni in dropdown... | Petronel Pavel | 2026-07-13 | Yes | |
| adservio/devops/iac!58 | adservio/devops/iac | fix db-users docs/scripts and add REFERENCES grant for library-user | andrei.petrescu@cloudhero.io | 2026-07-13 | Yes | |
| adservio/devops/iac!56 | adservio/devops/iac | upgrade prod RDS to r8g.xlarge (billing family switch m8g->r8g), keep catalog... | Rojan Shrestha | 2026-07-14 | ||
| adservio/helm2!313 | adservio/helm2 | ads-8246 disable alertmanager on staging | Rojan Shrestha | 2026-07-14 | ||
| adservio/frontend!2024 | adservio/frontend | [ADS-8247] -swapped first/last name in candidatesProfile | George Murgoci | 2026-07-15 | Yes | |
| adservio/frontend!2017 | adservio/frontend | [ADS-8245] Preferințe generale alignment | Petronel Pavel | 2026-07-15 | Yes | |
| adservio/helm2!314 | adservio/helm2 | ads-8253 route tuiasi critical alerts to pagerduty like prod | Rojan Shrestha | 2026-07-15 | ||
| adservio/uni/backend!231 | adservio/uni/backend | [ADS-8188] Extindere import studenți cu Secții | Andrei Alexandru | 2026-07-15 | Yes | |
| adservio/frontend!2001 | adservio/frontend | [ADS-7495][ADS-7496] Creare Probe evaluare | Achim Stefan | 2026-07-16 | Yes | Yes |
| adservio/frontend!2023 | adservio/frontend | [ADS-7475]: Plan de Invatamant - teste e2e fixes | Dana Mihaela Maritca | 2026-07-16 | Yes | |
| adservio/billing/backend!260 | adservio/billing/backend | Skip failing billing tests | George Murgoci | 2026-07-16 | Yes | |
| adservio/devops/iac!59 | adservio/devops/iac | add adservio-web-user-priviledged with delete-only access on public and store... | Rojan Shrestha | 2026-07-16 | ||
| adservio/helm2!312 | adservio/helm2 | tuiasi: fix superset and rabbitmq ingressClassName (private-traefik -> nginx) | Rojan Shrestha | 2026-07-16 | ||
| adservio/frontend!2021 | adservio/frontend | [ADS-7958] Reconstituire scolaritate - transfer, an repetare | Achim Stefan | 2026-07-16 | Yes | Yes |
| adservio/uni/backend!230 | adservio/uni/backend | [ADS-7958] Reconstituire scolaritate - transfer, an repetare | Andrei Alexandru | 2026-07-16 | Yes | Yes |
| adservio/uni/backend!228 | adservio/uni/backend | [ADS-7952] Atribute | Andrei Alexandru | 2026-07-16 | Yes | |
| adservio/uni/backend!222 | adservio/uni/backend | ADS-8000: fixuri si redenumiri pe localization | Francisc Gabriel Virlan | 2026-07-16 | ||
| adservio/docgen2/backend!150 | adservio/docgen2/backend | [ADS-8000]: redenumire loc | Dana Mihaela Maritca | 2026-07-16 | Yes | |
| adservio/frontend!1985 | adservio/frontend | [ADS-8000]: Redenumire atribut "loc" si transmitere doar in informatii generale | Dana Mihaela Maritca | 2026-07-16 | Yes | Yes |
| adservio/devops/iac!60 | adservio/devops/iac | db-users: add analytics user scoped to data schema, adopt manually created superset role | Rojan Shrestha | 2026-07-16 | ||
| adservio/helm2!291 | adservio/helm2 | [ADS-7497] Uni laravel - jwt secrets | Ionut Ciolan | 2026-07-17 | ||
| adservio/helm2!316 | adservio/helm2 | ADS-8274 Raise uni-core phpfpm-laravel memory to 2Gi/700Mi | Rojan Shrestha | 2026-07-17 | ||
| adservio/frontend!2025 | adservio/frontend | [ADS-6568] Director dashboard graph update | Petronel Pavel | 2026-07-17 | Yes | |
| adservio/frontend!2028 | adservio/frontend | [ADS-8141] Lipsa mesaj de eroare la modificarea mediei de absolvire | Achim Stefan | 2026-07-17 | Yes | |
| adservio/frontend!2022 | adservio/frontend | [ADS-8055]: Adaugare warning notele se vor pierde daca nu se salveaza pagina | Iuliana Gugeanu | 2026-07-17 | Yes | Yes |
| adservio/docgen2/backend!154 | adservio/docgen2/backend | [ADS-8269] De modificat fontul primei pagini | Petronel Pavel | 2026-07-17 | Yes | |
| adservio/web!2647 | adservio/web | [ADS-8257] Eroare 400 la debifare afisare in catalog a unui transfer intre clase | Petronel Pavel | 2026-07-17 | Yes | Yes |
Oldest Active Open MRs (> 48 Working Hours)
| adservio/web!2091 | adservio/web | Andrei Dragan | 261.5d | 5 | |
| adservio/helm2!137 | adservio/helm2 | Raul Popovici | 237.6d | 0 | |
| adservio/services/websocket!8 | adservio/services/websocket | Raul Popovici | 234.5d | 0 | |
| adservio/services/videothumb!5 | adservio/services/videothumb | Raul Popovici | 234.5d | 0 | |
| adservio/services/fet-generator!9 | adservio/services/fet-generator | Raul Popovici | 234.5d | 0 | |
| adservio/ai/backend!62 | adservio/ai/backend | Robert | 135.6d | 0 | |
| adservio/frontend!1556 | adservio/frontend | George Murgoci | 126.3d | 0 | |
| adservio/web!2344 | adservio/web | George Murgoci | 125.4d | 0 | |
| adservio/library/backend!26 | adservio/library/backend | Raul Popovici | 105.4d | 0 | |
| adservio/subscriptions/backend!103 | adservio/subscriptions/backend | Edgar Alexa | 103.4d | 4 |
Longest Merged Cycles
| adservio/frontend!1633 | adservio/frontend | Dragoș Ivan | 92.8d | 69 | 0 |
| adservio/helm2!291 | adservio/helm2 | Ionut Ciolan | 18.0d | 3 | 0 |
| adservio/uni/backend!219 | adservio/uni/backend | Ionut Ciolan | 17.3d | 59 | 16 |
| adservio/uni/backend!222 | adservio/uni/backend | Francisc Gabriel Virlan | 11.1d | 22 | 0 |
| adservio/frontend!1985 | adservio/frontend | Dana Mihaela Maritca | 10.0d | 25 | 0 |
| adservio/docgen2/backend!150 | adservio/docgen2/backend | Dana Mihaela Maritca | 9.3d | 8 | 0 |
| adservio/devops/iac!56 | adservio/devops/iac | Rojan Shrestha | 7.7d | 3 | 0 |
| adservio/accommodations/backend!73 | adservio/accommodations/backend | Ionut Ciolan | 7.4d | 12 | 0 |
| adservio/uni/backend!228 | adservio/uni/backend | Andrei Alexandru | 6.9d | 22 | 0 |
| adservio/frontend!2001 | adservio/frontend | Achim Stefan | 5.8d | 4 | 0 |
Methodology And Limits
- This report uses visible non-author GitLab comments as the strongest review-start proxy.
- GitLab approval API coverage is shown separately; missing approval API data should be read as traceability gap, not proof that no approval happened.
- Review completion uses the first `CR - Approved` label-add event after review starts when GitLab label history provides one; otherwise it falls back to merge time.
- Last-author-commit metrics use the latest non-merge MR commit authored by the MR author strictly before review starts.
- Timing metrics in this report exclude Saturday and Sunday hours using the Europe/Bucharest calendar.
- Review-quality scoring is heuristic: it rewards visible substantive comments, multiple reviewers, and post-review pushes, and it penalizes large MRs with shallow visible discussion.
- `Active open backlog rate` excludes draft MRs and uses a > 48 working-hour age threshold.
- Open MR backlog age is a queue-health signal, not proof that every old open MR is actively waiting for review right now.